Comments on: sfPropelPager and pagination http://blog.rajatpandit.com/2009/01/04/sfpropelpager-and-pagination/ Thoughts on Web Development, Infrastructure and Application Scalability Thu, 22 Dec 2011 14:24:07 +0000 hourly 1 http://wordpress.org/?v=3.3 By: cug http://blog.rajatpandit.com/2009/01/04/sfpropelpager-and-pagination/comment-page-1/#comment-2749 cug Fri, 23 Apr 2010 16:18:04 +0000 http://blog.rajatpandit.com/?p=106#comment-2749 nice example, thank you! maybe you should have used component instead of partial to separate code from view nice example, thank you!

maybe you should have used component instead of partial to separate code from view

]]> By: rp http://blog.rajatpandit.com/2009/01/04/sfpropelpager-and-pagination/comment-page-1/#comment-2716 rp Fri, 09 Apr 2010 16:46:17 +0000 http://blog.rajatpandit.com/?p=106#comment-2716 Ouch! that was a bit harsh! but you have a valid point. I am sure i am not the only developer who would agree with this, but essentially as a developer you would re-visit your code form months/years back and be ashamed of it but IMHO is if there was learning from it? and can you spot the difference between how you would write the same code much better now. If yes then its all good. I am glad you took a moment to leave your thoughts and I value it. This code is indeed really bad, but this again wasn't something to be used in production but just to see how it can be used. If you know what you are doing, you can handle that code properly. This code obviously is not production ready and I assumed that for the readers. Ouch! that was a bit harsh! but you have a valid point. I am sure i am not the only developer who would agree with this, but essentially as a developer you would re-visit your code form months/years back and be ashamed of it but IMHO is if there was learning from it? and can you spot the difference between how you would write the same code much better now. If yes then its all good.
I am glad you took a moment to leave your thoughts and I value it. This code is indeed really bad, but this again wasn’t something to be used in production but just to see how it can be used. If you know what you are doing, you can handle that code properly. This code obviously is not production ready and I assumed that for the readers.

]]> By: Lawrence Krubner http://blog.rajatpandit.com/2009/01/04/sfpropelpager-and-pagination/comment-page-1/#comment-2715 Lawrence Krubner Fri, 09 Apr 2010 16:36:10 +0000 http://blog.rajatpandit.com/?p=106#comment-2715 Interesting effort, but I would never let this partial into any project I was working on. There is too much code in the partial. Idiomatic Symfony code does not have code blocks in the templates or partials. Having overseen several Symfony projects, I've learned that when I see this kind of thing, it means the programmer is taking short cuts, not just with pagination, but with everything. Possibly you may need to do a custom pager class, and store it in /lib, but it is inappropriate to have this much code in a partial. Interesting effort, but I would never let this partial into any project I was working on. There is too much code in the partial. Idiomatic Symfony code does not have code blocks in the templates or partials. Having overseen several Symfony projects, I’ve learned that when I see this kind of thing, it means the programmer is taking short cuts, not just with pagination, but with everything.

Possibly you may need to do a custom pager class, and store it in /lib, but it is inappropriate to have this much code in a partial.

]]>